Closed thirumalai-qcom closed 1 month ago
This will need to be rebased now that #434 has been merged.
This will need to be rebased now that #434 has been merged.
Hi Ryan,
I have reviewed the mainline, and it seems that the changes in this PR have already been merged through PR #434. Could you please let me know if there are any specific reasons or additional changes you would like to see in this PR that necessitate a rebase?
If all changes in this PR are covered or superseded by #434, then this PR can simply be closed.
If all changes in this PR are covered or superseded by #434, then this PR can simply be closed.
I have confirmed that all changes in this PR have been covered by the changes merged from PR #434. Therefore, i will proceed to close this PR as it is no longer necessary.
Description
This pull request updates the OBS-browser module to the latest CEF (Chromium Embedded Framework) library. This update necessitates changes to existing function declarations and signatures to align with the new library's specifications. Additionally, ARM architecture support has been introduced, with modifications guarded by ARM-specific macros to ensure compatibility without affecting the existing codebase.
Motivation and Context
The primary motivation for this change is to keep the OBS-browser module up-to-date with the latest CEF library with the new features. Additionally, expanding compatibility to include ARM-based systems allows a broader range of users to benefit from the OBS-browser functionalities.
How Has This Been Tested?
The changes have been tested by building OBS Studio on an ARM machine (X elite machine). All builds were successful, Basic functionality tests confirmed that the OBS Studio application with the modified obs-browser is functional.
Types of changes
Checklist: