search

obsproject / obs-plugintemplate

GNU General Public License v2.0
285 stars 133 forks source link

Created release does not use plugin name #105

Closed CodeYan01 closed 8 months ago

CodeYan01 commented 9 months ago

Operating System Info

Windows 11

Other OS

No response

OBS Studio Version

30.0.0

OBS Studio Version (Other)

No response

OBS Studio Log URL

N/A

OBS Studio Crash Log URL

No response

Expected Behavior

Have the plugin name in the release title

Current Behavior

image

Creates a draft release titled OBS Studio. While it's fine because it is a draft, having a friendly name in buildspec.json would be great so that we don't have to change the title all the time. I already put 'media-playlist-source' as the name but being able to put 'Media Playlist Source' in release titles automatically would be useful.

Steps to Reproduce

  1. Push a tag to make a release
  2. Check the draft release

Anything else we should know?

No response

PatTheMav commented 9 months ago

@CodeYan01 please check with the changes added by #109.

CodeYan01 commented 8 months ago

Thanks, will report back when I get to it soon

CodeYan01 commented 8 months ago

@PatTheMav image

Yes, it did use the plugin name in the release. But I think it would be great if we could specify a "pretty-name" in the buildspec that it will use in the release title and installer. Like for this one, I would prefer to see "Media Playlist Source" (title case and no dashes).

PatTheMav commented 8 months ago

@CodeYan01 good point, I updated the PR - the buildspec now contains a key displayName that can be used for this and the old name will be used as a fallback if the former is not set. Also allowed me to make the regular expression more specific.