CI: Expose detected plugin name to other workflow jobs

obsproject / obs-plugintemplate

GNU General Public License v2.0

307 stars 141 forks source link

CI: Expose detected plugin name to other workflow jobs #109

Closed PatTheMav closed 11 months ago

PatTheMav commented 11 months ago

Description

Adds early detection of the configured plugin name in workflows so the name can be re-used in later workflows without the need to do a full repository checkout or installation of 3rd party utilities (e.g. the release creation step).

Motivation and Context

Reduce necessary fixup steps for plugin developers when finalising their releases.

Fixes https://github.com/obsproject/obs-plugintemplate/issues/105.

How Has This Been Tested?

Tested with a tagged release on a fork of the repository.

Types of changes

Performance enhancement (non-breaking change which improves efficiency)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

CodeYan01 commented 11 months ago

With the new displayName change, have you tested creating a new release, with a space in the displayName? I am getting an error: https://github.com/CodeYan01/media-playlist-source/actions/runs/7257209427/job/19770748632

PatTheMav commented 11 months ago

With the new displayName change, have you tested creating a new release, with a space in the displayName? I am getting an error: https://github.com/CodeYan01/media-playlist-source/actions/runs/7257209427/job/19770748632

Right, it's not supposed to be used for file names now that it can have spaces and other weird characters in it, forgot to remove that again.

PatTheMav commented 11 months ago

@CodeYan01 pls check again.

CodeYan01 commented 11 months ago

In the Issue, you commented that it will fallback to name if displayName is not available, but I'm getting an error when the field is not there. https://github.com/CodeYan01/media-playlist-source/actions/runs/7284773565

With the displayName it now works perfectly. https://github.com/CodeYan01/media-playlist-source/actions/runs/7284781779

Thank you!

PatTheMav commented 11 months ago

In the Issue, you commented that it will fallback to name if displayName is not available, but I'm getting an error when the field is not there. https://github.com/CodeYan01/media-playlist-source/actions/runs/7284773565

With the displayName it now works perfectly. https://github.com/CodeYan01/media-playlist-source/actions/runs/7284781779

Thank you!

Ah, good old pipefail, should be fixed in a bit.

CodeYan01 commented 11 months ago

Tested both cases, works now.