CI: Update softprops/action-gh-release to v2.0.4

RytoEX commented 4 months ago

Description

The softprops/action-gh-release action is the last remaining action in this repo that was still using node16. Updating should remove the associated warnings.

Motivation and Context

Want less CI warnings so the meaningful warnings stand out.

How Has This Been Tested?

It hasn't. I'm not sure how to test it, but I think @PatTheMav has done it in the past?

Types of changes

Tweak (non-breaking change to improve existing functionality)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[ ] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

PatTheMav commented 4 months ago

To test the action, just tag a release on your fork (after pushing the change to master) and check if it's created successfully.

After that, force-push the upstream master commit again to "undo" the changes (also force-push tags to remove the new tag as well).

RytoEX commented 4 months ago

To test the action, just tag a release on your fork (after pushing the change to master) and check if it's created successfully.

After that, force-push the upstream master commit again to "undo" the changes (also force-push tags to remove the new tag as well).

Thanks. Will try that.

RytoEX commented 4 months ago

Tested on my fork and got CI to be green with no warnings about node16.

During this, we discovered that if the repo does not have notarization/codesigning properly set up, macOS packaging will fail:

Prepare all required actions
Error: The template is not valid. RytoEX/obs-plugintemplate/.github/workflows/build-project.yaml@7c74a20ff2e9f491a0e74e27c9dd9ea6ac3b0d6f (Line: 147, Col: 21): Error reading JToken from JsonReader. Path '', line 0, position 0.

Line 147 is:

          notarize: ${{ fromJSON(needs.check-event.outputs.notarize) && fromJSON(steps.codesign.outputs.haveNotarizationUser) }}

After some off-thread discussion with @PatTheMav , we determined that haveNotarizationUser is an empty string, which seems to break fromJSON.

##[debug]......Evaluating String:
##[debug]......=> 'haveNotarizationUser'
##[debug]....=> ''
##[debug]RytoEX/obs-plugintemplate/.github/workflows/build-project.yaml@7c74a20ff2e9f491a0e74e27c9dd9ea6ac3b0d6f (Line: 147, Col: 21):

This is out-of-scope for this PR, but I wanted to document for posterity. It's something that we should address at some point.

obsproject / obs-plugintemplate