obsproject / obs-plugintemplate

GNU General Public License v2.0
289 stars 134 forks source link

Disable the "Directory already exists" warning in Windows installer #37

Closed tt2468 closed 2 years ago

tt2468 commented 2 years ago

Description

Because of course the directory exists, it's a plugin.

Motivation and Context

Don't want confusing dialogs popping up to users

How Has This Been Tested?

Used in obs-websocket

Types of changes

Checklist:

RytoEX commented 2 years ago

Is the warning basically saying, "The OBS Studio directory already exists, are you sure you want to install files here?" I'm not familiar with the context.

Fenrirthviti commented 2 years ago

Correct, the installer complains that the installation directory isn't empty/already exists, which is expected in basically 100% of cases.

tt2468 commented 2 years ago

This is from the obs-websocket installer. I also have a check to abort the installation if the directory doesn't exists which I can PR too. Helps with the classic "I installed the plugin but its not showing up" support case where users install to the wrong directory.