Auto generate plugin name in workflow

cg2121 commented 2 years ago

Description

This generates the plugin name based on the name in the buildspec file.

Motivation and Context

One less file for developers to change.

How Has This Been Tested?

Ran workflow.

Types of changes

Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

PatTheMav commented 2 years ago

I think the idea is sound, however the plugin name is defined in the buildspec.json file (the build script even updates CMakeList.txt with name and version with the values from it).

So IMO the "correct" change would be a step that parses the JSON file and sets that as an output variable that's then re-used throughout the workflow.

PatTheMav commented 1 year ago

@cg2121 I guess the most portable way would be to add code to the respective "Setup Environment" steps in the workflow to parse the buildspec file and then print that value to $GITHUB_OUTPUT so you can reuse it in the later workflow steps.

cg2121 commented 1 year ago

Updated to use the suggestion by @PatTheMav

obsproject / obs-plugintemplate