search

obsproject / obs-plugintemplate

GNU General Public License v2.0
307 stars 141 forks source link

Wrong packaging directory on macos #56

Closed summershrimp closed 1 year ago

summershrimp commented 2 years ago

Operating System Info

macOS 12

Other OS

No response

OBS Studio Version

28.0.3

OBS Studio Version (Other)

No response

OBS Studio Log URL

Nope

OBS Studio Crash Log URL

No response

Expected Behavior

Generate plugin pkg installer file.

Current Behavior

packages failed to packaging plugin to pkg installer file.

Steps to Reproduce

  1. run ./.github/script/package-macos.zsh

Anything else we should know?

https://github.com/obsproject/obs-plugintemplate/blob/c85ef7715130a11ec6718267c8d1ed1fc36f6b75/cmake/bundle/macos/installer-macos.pkgproj.in#L66

at installer-macos.pkgproj.in , @RELATIVE_INSTALL_PATH@ is expanded to build_x64/install

but at .build.zsh, plugin is installed to release

https://github.com/obsproject/obs-plugintemplate/blob/c85ef7715130a11ec6718267c8d1ed1fc36f6b75/.github/scripts/.build.zsh#L243

so package failed

summershrimp commented 2 years ago

It seems working on CI, but not working on my local computer.

progressmedia commented 2 years ago

Agreed. It is not working for me either and the very rough translations from readme don't exactly help.

paulpv commented 1 year ago

Might this be fixed by https://github.com/obsproject/obs-plugintemplate/pull/41/files ?

RytoEX commented 1 year ago

41 was closed by #76, so this should be resolved.