obsproject / obs-plugintemplate

GNU General Public License v2.0
307 stars 141 forks source link

Add contents write permission to create release #62

Closed umireon closed 1 year ago

umireon commented 1 year ago

Description

Adding the contents write permission enables the make-release job to create a release.

Motivation and Context

A GitHub Actions job has read-only permission by default and it cannot create releases without configurations.

How Has This Been Tested?

Tested on my plugin repository. https://github.com/umireon/obs-pokemon-sv-helper

Types of changes

Checklist:

glikely commented 1 year ago

I don't understand why this change is necessary. I've been able to generate releases using the same template repo without this change. What specifically does adding write permission help with that doesn't work without it?

umireon commented 1 year ago

The default permission of GITHUB_TOKEN was recently changed from write-all to read-all and new repositories will be affected.

https://github.blog/changelog/2023-02-02-github-actions-updating-the-default-github_token-permissions-to-read-only/

glikely commented 1 year ago

Okay, thanks for the explanation