obsproject / obs-plugintemplate

GNU General Public License v2.0
307 stars 142 forks source link

Fix locale files path on Windows #63

Closed CodeYan01 closed 1 year ago

CodeYan01 commented 1 year ago

Used to put the locale files in PLUGIN-NAME/data/locale/*.ini, with an extra data folder, which prevented obs from finding the locale files.

Description

Used to put the locale files in PLUGIN-NAME/data/locale/*.ini, with an extra data folder, which prevented obs from finding the locale files.

Motivation and Context

My plugin at https://github.com/CodeYan01/media-playlist-source used this plugin, and the locale file wasn't being found by OBS.

How Has This Been Tested?

Regenerated cmake, and verified that the locale file is loaded.

Types of changes

Checklist:

PatTheMav commented 1 year ago

Did you check if this has any side-effects on macOS or Linux?

CodeYan01 commented 1 year ago

I apologize, I misread the cmake and thought it was under an If windows block. Re-read it and saw it is done for windows and linux.

I don't have a setup to test on linux yet, so I asked Penwywern to see if it works on their OBS on linux (https://discord.com/channels/348973006581923840/636682839382949888/1079512110524014707), and they said they saw "Media Playlist Source" in the source list, meaning it loads the locale file properly. Ubuntu 22.04, OBS 29.0.2 ppa