search

obsproject / obs-plugintemplate

GNU General Public License v2.0
307 stars 142 forks source link

Use `example.com` as placeholder, fixes #70 #71

Closed qwertychouskie closed 1 year ago

qwertychouskie commented 1 year ago

mywebsite.com redirects to a phishing/tech support scam, see #70 for details. Instead use example.com, which is reserved by IANA specifically for use as an example/placeholder.

Fixes #70.

glikely commented 1 year ago

Instead of a generic url, what about defaulting to an OBS link, like https://obsproject.com/forum/plugins/ ?

PatTheMav commented 1 year ago

While this change is fine, it should probably use a CMake replacement instead, because it wasn't explicitly mentioned to change it and alas people did not change it.

Best case scenario it should fail compilation if no valid value is configured via CMake and a corresponding field added to the build spec file.

qwertychouskie commented 1 year ago

While this change is fine, it should probably use a CMake replacement instead, because it wasn't explicitly mentioned to change it and alas people did not change it.

Best case scenario it should fail compilation if no valid value is configured via CMake and a corresponding field added to the build spec file.

I agree that would be a good follow-up, but IMHO the stop-gap of not including a link to a scam website should be merged first to limit the potential for damage.

Fenrirthviti commented 1 year ago

As a note: https://www.virustotal.com/gui/url/732ae85361f5efdfa26f0185fdd9e83e2294698648f859e0da42287c7fbb991a

This doesn't seem to be any kind of active scam at the moment, and I can't find any actual evidence that it ever was. I wouldn't be surprised if there was some kind of DNS issue that was causing the redirect problem. I'd rather this be fixed correctly using the cmake method than merging this which is just going to get replaced shortly after, or worse, forgotten about.

qwertychouskie commented 1 year ago

The issue is well documented in https://github.com/obsproject/obs-plugintemplate/issues/70 and https://github.com/obs-ndi/obs-ndi/issues/455#issuecomment-1463064888

Although the redirect to the blatant scam website is not currently active, the domain currently redirects to a strange landing page website infosayz.com: Screen Shot 2023-03-13 at 19 10 37-fullpage

The site is apparently operated by "VPP Technologies LLC": Screen Shot 2023-03-13 at 19 11 17-fullpage

Searching their name/address sent me down quite the strange rabbit hole, from a strange chrome extension that has 20,000+ users but only 1 rating and 0 reviews, to what is apparently their main business site, but is straight out of 2008 (literally): Screen Shot 2023-03-13 at 19 16 07-fullpage

Nothing here adds up, and my susometer is off the charts. It's hard to believe that a business that apparently solely exists to add stock images to text ads could survive through legitimate means in 2008, much less 2023. As an additional nail in the coffin, Dr.Web reports that site as a "known infection source": Screen Shot 2023-03-13 at 19 29 28-fullpage

The URL should definitely be changed to something trustworthy as soon as possible, more advanced mechanisms like defining it via CMake can come later.

Fenrirthviti commented 1 year ago

Updating cmake is not "advanced" when you consider it's a requirement of and core function of the template. It's barely any more work than this current PR:

Simply add set(PLUGIN_WEBSITE "https://www.example.com") to CMakeLists.txt (probably under the PLUGIN_AUTHOR section right at the top) and change the line in the installer script to be #define MyAppURL "@PLUGIN_WEBSITE@"

That's it.

RytoEX commented 1 year ago

Superseded by #75