Closed Fenrirthviti closed 1 year ago
Commit title could probably be adjusted to something like cmake: Use example.com as placeholder website
to remove the "fixes" part. Unsure what our stance on the fixes
tag in the commit body is.
And technically the commit body is too long but I doubt anyone ever checks the plugintemplate commit history in such detail :P
Commit title could probably be adjusted to something like
cmake: Use example.com as placeholder website
to remove the "fixes" part.
We don't have well enforced rules on this repository for it, but we can edit this, yes.
Unsure what our stance on the
fixes
tag in the commit body is.
We don't have a stance. It's fine either in the PR description, or the commit message body, or both. The downside of mentioning in the commit message body is that every time the commit is updated and force-pushed, the linked Issue will get a new unique notification.
Updated commit title/description.
Fixes #70.
Supersedes #71 as the correct fix rather than placeholder. Keeps original authorship from #71 as well.
Closes #71
Description
Adds a variable to cmake for specifying the website, and changes the default to example.com which is safer than mywebsite.com.
Motivation and Context
Don't like bad websites.
How Has This Been Tested?
Tested locally, works
Types of changes
Checklist: