obsproject / obs-plugintemplate

GNU General Public License v2.0
307 stars 142 forks source link

macOS build of plugin excludes files from libobs's util directory #88

Closed nhielost closed 1 year ago

nhielost commented 1 year ago

Operating System Info

macOS 13

Other OS

No response

OBS Studio Version

Other

OBS Studio Version (Other)

29.1.2

OBS Studio Log URL

N/A

OBS Studio Crash Log URL

No response

Expected Behavior

My plugin should build without errors from libobs on macOS using GitHub Actions.

Current Behavior

The GitHub Actions build succeeds for all OSes except for macOS. A "file not found" error from the line #include <util/config-file.h> is why the build stops.

Error

More testing indicated that some files in the resulting libobs/util include directory were missing, as shown below.

Missing Files

Steps to Reproduce

  1. Generate from this repo.
  2. Add #include <util/config-file.h> to the source code.
  3. Commit and push.
  4. The macOS run fails.

Anything else we should know?

The other libobs include files and directories are all there. It is only the util directory that is having this problem. Also, this has occurred every time I have run the workflow - it is not a one-time thing.

gxalpha commented 1 year ago

This should be fixed with OBS 30.

ShigemoriHakura commented 1 year ago

Is this bug fixed? I'm using 30.0.0-rc1 but still has this issue both on Actions and local.

gxalpha commented 1 year ago

@ShigemoriHakura did you change the buildspec to point to the RC? If so, could you post the error (or link the repo)?

ShigemoriHakura commented 1 year ago

@ShigemoriHakura did you change the buildspec to point to the RC? If so, could you post the error (or link the repo)?

fixed, now I can build the project properly.