Closed paulpv closed 10 months ago
You might want to check if there are other invocations of gh
that might require an explicit PR number or Git reference (I remember we had to add those to obs-studio
's code at some points) and it would be great if we could clean up all invocations of the CLI tool with this PR.
You might want to check if there are other invocations of
gh
that might require an explicit PR number or Git reference (I remember we had to add those toobs-studio
's code at some points) and it would be great if we could clean up all invocations of the CLI tool with this PR.
I don't see any other uses of gh
in this project.
Also updating
.github\workflows\build-project.yaml
with a few of the latest compatible changes in obs-studio's same file.Description
Fixing
.github/workflows/build-project.yaml
GITHUB_EVENT_NAME
pull_request
gh
failing and reporting "could not determine current branch".Motivation and Context
.github\workflows\build-project.yaml
has some code that supports packaging the plugin with aSeeking Testers
label. https://github.com/obsproject/obs-plugintemplate/blob/57cdde9d8120b7b196a2c4612131b3078f893ad9/.github/workflows/build-project.yaml#L32-L36This wasn't working because![image](https://github.com/obsproject/obs-plugintemplate/assets/1393897/0d123533-8fb6-4de1-b3c8-4a38a9e7ce64)
gh
complained "could not determine current branch": https://github.com/obsproject/obs-plugintemplate/actions/runs/6657042057/job/18090925431This code is based on obs-studio's: https://github.com/obsproject/obs-studio/blob/64be5a7f9a90c6d2159ba60613d0fc421c40621c/.github/workflows/build-project.yaml#L32-L36
@PatTheMav might have noticed this wasn't working in obs-studio and fixed it with the following on 2023/09/05: https://github.com/obsproject/obs-studio/commit/a2c0d4969aa35067455814d20cc87f9f9486c370#diff-58a222b2569531e3ee88d373cb6b2a3b0e4d1b24ebd09ba9d03e12b6f110bb03R32
I copied that one line32 change and now the "Seeking Testers" feature works. While I was in that file I also copied a few of the other compatible changes.
How Has This Been Tested?
https://github.com/obs-ndi/obs-ndi/actions/runs/6748286871 ran with this change and the "Seeking Testers" label and correctly packaged the installers.
Types of changes
Checklist: