search

obsproject / obs-plugintemplate

GNU General Public License v2.0
285 stars 133 forks source link

target OBS 30.0.0 #98

Closed sorayuki closed 9 months ago

sorayuki commented 9 months ago

Description

Motivation and Context

Build towards the latest release of obs-studio.

How Has This Been Tested?

It works for my obs-multi-rtmp plugin.

Types of changes

Tweak (non-breaking change to improve existing functionality)

Checklist:

paulpv commented 9 months ago

As intended, this just updates the OBS version and dependencies to OBS v30. Would it also be worthwhile to update the scripts themselves to OBS 30 content? (where appropriate)

sorayuki commented 9 months ago

I don't know what changes are made to the script. Any hints?

paulpv commented 9 months ago

I don't know what changes are made to the script. Any hints?

You would have to clone both this repo and https://github.com/obsproject/obs-studio and compare their build script folders.

There will be many differences, but a lot of obs-studio's should be ported over to this repo.

RytoEX commented 9 months ago

As intended, this just updates the OBS version and dependencies to OBS v30. Would it also be worthwhile to update the scripts themselves to OBS 30 content? (where appropriate)

It is preferable to keep PRs narrowly scoped in purpose.

PatTheMav commented 9 months ago

The checklist in the PR template is not informative (telling us about the PR) but instructive (telling you which rules the PR has to follow).

As you opened the PR with your master branch as the source we cannot merge this because you won't be able to check the "My code is not on the master branch." checkbox (you can't change a PR's source branch after it has been opened).

PatTheMav commented 9 months ago

@sorayuki Just FYI, you should keep the master branch on your fork to keep it in sync with the master branch on the main repository here (that way you can easily keep up with changes we merge here).

Then you create a new branch off the master branch, commit your change on that branch and open a pull request targeting the master branch (e.g. <your account>/<your fork>/patch-1 -> obsproject/obs-plugintemplate/master).

That way you can fast-forward your master branch with any changes we might have merged here, while your branch containing the change can stay as-is (as long as your changes don't conflict).

sorayuki commented 9 months ago

I was trying to rename the source branch of pull request, and result in showing the source branch is deleted...

PatTheMav commented 9 months ago

I was trying to rename the source branch of pull request, and result in showing the source branch is deleted...

Ah ok, yeah that makes sense. Thank you for understanding and reopening though.