CI: Fix random password generation for macOS codesigning - Githubissues

obsproject / obs-plugintemplate

GNU General Public License v2.0

285 stars 133 forks source link

CI: Fix random password generation for macOS codesigning #99

Closed paulpv closed 9 months ago

paulpv commented 9 months ago

sha1sum is part of Homebrew's coreutils, but macOS ships with shasum by default, which supports many variants and defaults to SHA-1 by default. This is essentially a cherry-pick of: https://github.com/obsproject/obs-studio/commit/1e74256b7ea438f01d3146d3411246215a19cbf5

Description

Build is outputting this error:

Run : macOS Codesigning ✍️
/Users/runner/work/_temp/f1d2ceff-9fa3-45ff-9e47-d545a0f36982:12: command not found: sha1sum

Motivation and Context

@PatTheMav noticed this in the OBS build and fixed it there: https://github.com/obsproject/obs-studio/commit/1e74256b7ea438f01d3146d3411246215a19cbf5 Doing the same here.

How Has This Been Tested?

Build no longer outputs:

Run : macOS Codesigning ✍️
/Users/runner/work/_temp/f1d2ceff-9fa3-45ff-9e47-d545a0f36982:12: command not found: sha1sum

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.