obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording
https://obsproject.com
GNU General Public License v2.0
57.77k stars 7.74k forks source link

FFMPEG warnings flooding OBS log #10134

Open yahoo1999 opened 6 months ago

yahoo1999 commented 6 months ago

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

Other

OBS Studio Version (Other)

30.0.0

OBS Studio Log URL

https://pastebin.com/VQu45BFg

OBS Studio Crash Log URL

No response

Expected Behavior

I would expect logger to ignore repeated lines in some way or another, generating 300GB log file is unacceptable.

Current Behavior

Log file gets flooded with FFMPEG errors, generated hundreds of times per 0.001s

Steps to Reproduce

  1. Add a HLS input via Media Source
  2. Have the input stream cause FFMPEG to produce warning: inflate return value: -3, incorrect header check error (I am unsure what exactly casues those kinds of errors)
  3. Log file gets flooded with approximately hundreds of warnings per 0.001s

Anything else we should know?

Media source Input was a M3U8 URL, Input Format was set to hls. I am not sure if this is correct way to do it but it resulted in working input.

I left OBS running in the background, at some point the stream probably errored out FFMPEG and the flood gates were opened.

Last 1000 lines of log uploaded to pastebin, since the original file got up to 286GBs.

I noticed what's happening just as my system was running out of storage, fortunately. If I didn't it could possibly cause some serious trouble.

image_2024-01-24_042028379

Fenrirthviti commented 6 months ago

Please provide the full log file header portion.

yahoo1999 commented 6 months ago

First 400 lines of log

2024-01-23 21-19-39+400.txt

Fenrirthviti commented 6 months ago

Thanks, can you test on 30.0.2 as well? I had thought we fixed this already.

yahoo1999 commented 6 months ago

I have absolutely no idea how to trigger this problem with a stream honestly, I may try leaving it running in the background again today and see where it goes 😅 I just know it happens sometimes based on my experience of playing it out with MPV.

yahoo1999 commented 6 months ago

Running 30.0.2 now, looks like the encoder of stream I am sourcing into OBS had some hiccups in the meantime, and while FFMPEG had troubles reaching it it was flooding log again, not as destructive as last time, but I would still call it unexpected behavior. If the issues persisted it could result with huge logfile again. This time it wasn't exactly repeated messages though.

2024-01-24 07-04-54redacted.txt

RytoEX commented 6 months ago

This is strange because we do have duplicate log line filtering in our logging code. I wonder if the FFmpeg logging bypasses that?

yahoo1999 commented 5 months ago

2024-01-25 16-05-02redacted.txt

Tested on 30.0.2

I would say yes, it does appear to bypass it. Unfortunately analyzing the code is slightly above my paygrade.