search

obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording
https://obsproject.com
GNU General Public License v2.0
57.27k stars 7.72k forks source link

NVIDIA Noise Removal Filter breaks when changing its value (since updating to OBS 30) #10637

Open m0m0herde opened 2 months ago

m0m0herde commented 2 months ago

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

30.1.2

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/stteKLwsTykEl2wQ

OBS Studio Crash Log URL

No response

Expected Behavior

Same as in OBS 29.x: The NVIDIA Noise Removal filter should always work at every selected value.

Current Behavior

Adding the Noise Suppression Filter to an audio source and then selecting the "NVIDIA Noise Removal" option makes the filter work at 100% (value 1.0). Changing the value causes the filter to stop working completely, even when reverting to value 1.0. Restarting OBS, while the filter is still active regardless of the value, makes the filter work again, but only at 100%/1.0, even if a different value was selected beforehand.

Steps to Reproduce

  1. Add the Noise Supression Filter to an audio source
  2. Select NVIDIA Noise Removal
  3. Change the value
  4. Filter stops working

Anything else we should know?

Started happening after updating to OBS 30. NVIDIA Audio SDK is updated to the latest version. This bug is probably related to these lines in the log file: [noise suppress: 'Noise Suppression'] NvAFX_Load() failed with error 1 [noise suppress: 'Noise Suppression'] NvAFX_Release() failed [noise suppress: 'Noise Suppression'] NVAFX SDK redist path was found here C:\Program Files\NVIDIA Corporation\NVIDIA Audio Effects SDK

pkviet commented 2 months ago

Try uninstalling StreamFx. It also tries to load the nvidia noise reduction dll.

m0m0herde commented 2 months ago

uninstalled StreamFx, but didn't help: https://obsproject.com/logs/MzJBm8xiTftnPFbv

Penwy commented 2 months ago

Just to check causality:

pkviet commented 2 months ago

Also try the nvidia pr I authored, factoring out noise removal. It includes changes which might help stability. On my side, i'm unable to repro with 30.1 Link to PR: https://github.com/obsproject/obs-studio/pull/9457

Amir-mal commented 2 months ago

https://github.com/obsproject/obs-studio.git

Amir-mal commented 2 months ago

https://github.com/obsproject/obs-studio.git