UI: Fix config class mismatch in OBSApp class - Githubissues

obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording

https://obsproject.com

GNU General Public License v2.0

60.38k stars 7.99k forks source link

UI: Fix config class mismatch in OBSApp class #11293

Closed PatTheMav closed 2 months ago

PatTheMav commented 2 months ago

Description

Aligns the config type of several OS-specific settings across their implementations in the OBSApp class.

Motivation and Context

Ensure selection of renderer on Windows and VSync settings on macOS are correctly retained and restored from settings.

How Has This Been Tested?

Tested on macOS 15.

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

RytoEX commented 2 months ago

These changes look okay. Though, there is at least one other place where DisableAudioDucking is attached to userConfig or App()->GetUserConfig(): https://github.com/obsproject/obs-studio/blob/b9808eaca82340132c56e1577ae58a1e8747a119/UI/window-basic-settings.cpp#L2994-L2995

PatTheMav commented 2 months ago

These changes look okay. Though, there is at least one other place where DisableAudioDucking is attached to userConfig or App()->GetUserConfig():

https://github.com/obsproject/obs-studio/blob/b9808eaca82340132c56e1577ae58a1e8747a119/UI/window-basic-settings.cpp#L2994-L2995

Fixed that one and the others too.