obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording
https://obsproject.com
GNU General Public License v2.0
60.39k stars 7.99k forks source link

UI: Fix handling of Amazon IVS auto URLs when using multitrack video output #11525

Open palana opened 3 days ago

palana commented 3 days ago

Description

Allow multitrack video to work with Amazon IVS Auto (RTMPS) and Auto (RTMP) server entries selected

Motivation and Context

Amazon IVS uses two auto entries:

since channels by default only allow RTMPS, not RTMP (RTMP is a separate toggle when creating/modifying the channel).

With multitrack video, the effective server for "auto" entries is selected by the GetClientConfiguration call, where the response both RTMPS and RTMP entries generally; which of these should be used depends on whether RTMPS or RTMP is selected, hence the preference of using RTMP or RTMPS needs to be visible to the multitrack video output.

How Has This Been Tested?

Streamed up to an Amazon IVS channel with "Auto (RTMP)" and "Auto (RTMPS)" selected, and checked the log for the correct protocol

Types of changes

Checklist:

koolscooby commented 3 days ago

Note: this is a bugfix for functionality introduced in https://github.com/obsproject/obs-studio/pull/10634. Without it, if Amazon IVS and Auto (RTMPS, Recommended) or Auto (RTMP) are selected, an error dialog pops up "Invalid Path or Connection URL" and in the logs:

13:53:21.905: [rtmp stream: 'rtmp multitrack video'] Connecting to RTMP URL auto-rtmps...
13:53:21.907: RTMP URL: No :// in url!
13:53:21.907: [rtmp stream: 'rtmp multitrack video'] Connection to auto-rtmps failed: -1