search

obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording
https://obsproject.com
GNU General Public License v2.0
58.68k stars 7.81k forks source link

"Pick a font" and "Select color" windows are not on Crowdin #3598

Open dr03ramos opened 3 years ago

dr03ramos commented 3 years ago

Platform

Operating system and version: Windows 10 OBS Studio version: OBS 26.0.2 (64-bit)

Expected Behavior

Translators should be able to translate that screens on Crowdin. image image

Current Behavior

The texts are not on Crowdin.

Steps to Reproduce

  1. Open OBS and add a text source
  2. Click "Select font"
  3. Take any string (e.g. "Writing System") and search it on OBS project on Crowdin
  4. Note that the string is missing and isn't translatable

Additional information

WizardCM commented 3 years ago

I noticed this earlier in the year.

We have two potential directions to go:

  1. We create our own translation keys in our standard .ini files. This may require some tweaking (to strip out symbols & spaces in translation keys, for example).
  2. We include the standard Qt translation files as a fallback, and use the standard QTranslator capability. I don't know what the process would be to add these translation files to OBS.

I've been able to make the first option functional, but am not a fan of potentially creating many, many translation keys for something that could unexpectedly change in a Qt update. https://github.com/WizardCM/obs-studio/commit/7679e52e1b8ebfb484a2dd33eef9220f8a1e8716

WizardCM commented 3 years ago

After a quick test, looks like while https://github.com/obsproject/obs-studio/commit/c4840ddba05a8c2d01568445645097704595ea47 does set the Qt locale which would affect these dialogs, we don't ship Qt translation files so the text continues to fall back to English.