obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording
https://obsproject.com
GNU General Public License v2.0
60.32k stars 7.99k forks source link

auth-twitch: Remove API v5 reference in favour of Helix #3941

Closed Marenthyu closed 2 years ago

Marenthyu commented 3 years ago

Intention

If my search of the repository is correct, the following line is the single (remaining) reference to Twitch's v5/kraken API, which is discouraged to be used and will be discontinued at some point soon™.

https://github.com/obsproject/obs-studio/blob/cab32e7e67c2a78d10e0961f746ee7408978fb43/UI/auth-twitch.cpp#L79

This should be replaced with authenticated calls to https://dev.twitch.tv/docs/api/reference#get-stream-key and https://dev.twitch.tv/docs/api/reference#get-users to get the stream key and user name, respectively.

Reason

This change ensures longer-term usability of this version of OBS, in anticipation of the v5 shutdown, which has not yet been announced but is still scheduled to happen eventually (aka SOON™); The addition of the v5 Migration Guide to the Twitch Dev Docs shows that it is still very much on the radar for Twitch.

Considerations

Notable changes for this:

Marenthyu commented 2 years ago

Fixed with 92f5afae5191ac97f8449b8f7ac57007ccb5b373