search

obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording
https://obsproject.com
GNU General Public License v2.0
59.17k stars 7.86k forks source link

Crash on removing VST plugin filter (also when changing scene collection or exiting OBS) #4773

Open dvangennip opened 3 years ago

dvangennip commented 3 years ago

Operating System Info

macOS 10.15

Other OS

No response

OBS Studio Version

27.0.0-rc6

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/AE-o5-EAUZGByjwJ

OBS Studio Crash Log URL

https://www.dropbox.com/s/kbgps5z2neuz5iw/obs_crash.log?dl=0

Expected Behavior

When removing a VST plugin, or closing a scene collection with a VST plugin filter present on a source, for the plugin to be removed or scene collection to switch.

Current Behavior

OBS crashes to desktop whenever a VST plugin filter is removed.

Steps to Reproduce

  1. Add a VST plugin filter to any audio source
  2. Try to exit OBS or switch scene collection
  3. Crash ...

Anything else we should know?

No problems occured on OBS v26, but problem was present on earlier v27 RC 4. VST plugin tested was TDR Kotelnikov: https://www.tokyodawn.net/tdr-kotelnikov/ (free).

My first attempt at writing up this report and the accompanying logs were for a crash when changing scene collections and/or exiting OBS entirely. I've now worked out it happens whenever my tested VST plugin is removed, which hopefully narrows the scope.

WizardCM commented 3 years ago

Looking at the function in question, the only change was an added unloadEffect() call at the end.

dvangennip commented 3 years ago

Apologies, I did some further testing and found it happens even when just removing the VST plugin. I've just done the same on OBS 26.1.2 on my mac and no issue there.

Test 1

It's getting late here but I ran a quick test without any plugins installed, same crash, so it's unlikely to be a plugin.

Test 2

Removing all scene collection data, test on a fresh collection does not crash...

Looks like I'll have to try a few more things to find the source of the issue.

PatTheMav commented 3 years ago

I've been trying to reproduce this with a whole lot of VSTs but without success. I did get errors about UI calls being made off the main thread, but no crashes so far.

snowliondev commented 3 years ago

The crash happens only when I use more than one of the same VST plugin in the whole scene - apparently OBS can’t handle two plugins in the same scene - even in different devices - It doesn’t matter which plugin - you can reproduce it reliable. I'm on Mac with OBS 27. Same things happens with 26.

olbj commented 2 years ago

Hi. I can verify that the problem still exists. My OBS crashes on exit and when I change scene collection when I use the same VST plug-in several times for different mics in the same scene.

OBS 27.4.2 MacOS 12.5. Intel version.

RytoEX commented 1 year ago

Please retest in OBS Studio 28.1.2 (or newer) with no third-party plugins installed to confirm whether or not this is still an issue.