obs_scene_reorder_items() returns false instead of true when items are already correctly ordered - Githubissues

obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording

https://obsproject.com

GNU General Public License v2.0

60.19k stars 7.97k forks source link

obs_scene_reorder_items() returns false instead of true when items are already correctly ordered #6401

Open Mat1971 opened 2 years ago

Mat1971 commented 2 years ago

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

Git

OBS Studio Version (Other)

No response

OBS Studio Log URL

N/A

OBS Studio Crash Log URL

No response

Expected Behavior

obs_scene_reorder_items() should return true if the items do not need reordering

Current Behavior

obs_scene_reorder_items() returned false when the items did not need reordering

Steps to Reproduce

Supply a list of scene items in the same order as they already exist.

Anything else we should know?

Suggested fix:

https://github.com/obsproject/obs-studio/blob/master/libobs/obs-scene.c Line 2909 should return order_matches instead of false.

RytoEX commented 2 years ago

If you have a suggested fix, please submit a PR instead of an Issue.