search

obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording
https://obsproject.com
GNU General Public License v2.0
60.26k stars 7.98k forks source link

Audio Source's monitor stays active when source visibility is off and source has show/hide transitions #6435

Open Pablomx2 opened 2 years ago

Pablomx2 commented 2 years ago

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

27.2.4

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/8bhcb-eWuvrU-AML

OBS Studio Crash Log URL

No response

Expected Behavior

When changing a scene, the source transition should be completed no matter if the new scene contains the source or not.

Current Behavior

When triggering a Source's visibility transition by toggling the source's visibility and switching to a scene where the source doesn't exist, the transition fails to completely turn off the source. The output of it will be turned off, but monitoring capabilities of the audio source aren't will prevail with the status before toggling the source visibility

Please find a video explanation attached;

https://user-images.githubusercontent.com/53283603/167283299-6174f83d-a9a9-442e-ae2e-b81628394491.mp4

.

Steps to Reproduce

  1. Add an audio source.
  2. Give the audio source a show/hide transition, in this case Fade in 2000ms and Fade out 3000ms.
  3. Hide the source and immediately show it.
  4. Switch to a scene missing the audio source right after toggling visibility ON.
  5. Hear the monitoring of the source while the output can't.

Anything else we should know?

User that brought this to my attention is IonicEcko#0001 (113247697296736256) on Discord. Message . Their Log

IonicEcko commented 2 years ago

Can confirm, also an issue on Windows 11.

norihiro commented 2 years ago

I can also confirm on Linux (Fedora 34). At the step 3, it's not necessary to immediately show it. The issue happens when transit to another scene while the show-transition is running.

IonicEcko commented 2 years ago

Also should mention, there seems to also be issues when switching to another scene with the same audio source, it does not have to be missing.

I have a Spotify scene which just has an audio capture of the spotify application (Spotify outputs to a specific virtual audio cable). I have seen this issue switching between scenes where the source is still embedded in the scene (the spotify scene is in the destination scene) but I still see the same issue (while the source is hidden - spotify continues playing through the monitor (incorrectly) but does not output to the stream)

unional commented 2 years ago

Notice the same issue in the Audio Mixer in obs 28