obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording
https://obsproject.com
GNU General Public License v2.0
57.22k stars 7.72k forks source link

error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call] #9110

Open yurivict opened 1 year ago

yurivict commented 1 year ago

Operating System Info

Other

Other OS

FreeBSD

OBS Studio Version

29.1.2

OBS Studio Version (Other)

No response

OBS Studio Log URL

n/a

OBS Studio Crash Log URL

No response

Expected Behavior

Build succeeds.

Current Behavior

/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:201:54: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    explicit JsonString(string &&value)      : Value(move(value)) {}
                                                     ^
                                                     std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:209:58: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    explicit JsonArray(Json::array &&value)      : Value(move(value)) {}
                                                         ^
                                                         std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:217:60: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    explicit JsonObject(Json::object &&value)      : Value(move(value)) {}
                                                           ^
                                                           std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:259:72: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
Json::Json(string &&value)             : m_ptr(make_shared<JsonString>(move(value))) {}
                                                                       ^
                                                                       std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:262:71: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
Json::Json(Json::array &&values)       : m_ptr(make_shared<JsonArray>(move(values))) {}
                                                                      ^
                                                                      std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:264:72: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
Json::Json(Json::object &&values)      : m_ptr(make_shared<JsonObject>(move(values))) {}
                                                                       ^
                                                                       std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:362:21: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
        return fail(move(msg), Json());
                    ^
                    std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:154:46: error: unqualified call to 'std::move' [-Werror,-Wunqualified-std-cast-call]
    explicit Value(T &&value)      : m_value(move(value)) {}
                                             ^
                                             std::
/usr/ports/multimedia/obs-studio/work/obs-studio-29.1.3/deps/json11/json11.cpp:201:48: note: in instantiation of member function 'json11::Value<json11::Json::STRING, std::string>::Value' requested here
    explicit JsonString(string &&value)      : Value(move(value)) {}
                                               ^

Steps to Reproduce

Regular build.

Anything else we should know?

clang-15

tytan652 commented 1 year ago

Will be fixed by the in-progress replacement of json11 by Nlohmann JSON.

emaste commented 2 weeks ago

Addressed in the interim by 4d6e17c54759d72d03c31a1086044dc907d556b7 I believe