obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording
https://obsproject.com
GNU General Public License v2.0
57.29k stars 7.72k forks source link

Keep Keyboard shortcuts (hotkeys) if plugin is not updated/loaded #9464

Open msmafra opened 10 months ago

msmafra commented 10 months ago

Operating System Info

Other

Other OS

Fedora 38

OBS Studio Version

30.0.0-beta1

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/4zNOhnSjlczh4jsh

OBS Studio Crash Log URL

No response

Expected Behavior

Keep my plugin related keyboard shortcuts, even if the plugin is not loaded.

Current Behavior

Lost all (set at OBS' Hotkey window) plugin related keyboard shortcuts because the plugin was not updated, so it wasn't loaded.

Steps to Reproduce

  1. Install a plugin like Moving Transition
  2. Set some shortcuts
  3. Upgrade OBS
  4. Check the shortcuts

Anything else we should know?

This is probably not a bug, but keeping the shortcuts saved even if the plugin is not loaded or installed, seems, to me, a good idea. Maybe asking for removal if not detected; group them by plugin inside the Hotkeys scene related to it.

gxalpha commented 10 months ago

Can confirm that for a Move Source filter (of the Move plugin) if the filter had a hotkey registered on the source, then the plugin doesn't exist when OBS is started but gets readded at a later time, the hotkey is unset. This unfortunately might be pretty hard to fix due to the way that settings are saved.