search

obsproject / obs-studio

OBS Studio - Free and open source software for live streaming and screen recording
https://obsproject.com
GNU General Public License v2.0
58.84k stars 7.83k forks source link

[MINOR] Window position now shifts after maximize toggle #9938

Open anrxc opened 9 months ago

anrxc commented 9 months ago

Operating System Info

Windows 10

Other OS

No response

OBS Studio Version

30.0.0

OBS Studio Version (Other)

No response

OBS Studio Log URL

None

OBS Studio Crash Log URL

No response

Expected Behavior

Window returns to exact position in which it was before being maximized.

Current Behavior

When window is maximized and then un-maximized the window position of OBS Studio shifts by several pixels downwards.

If I was to guess, I would guess that for every maximize toggle the window position shifts by the pixel count of the current height of the Windows 10 taskbar.

Steps to Reproduce

  1. (Maintainer edit:) Be on Windows 10 (or force the old taskbar on Windows 11), and move taskbar to the top or right. See https://github.com/obsproject/obs-studio/issues/9938#issuecomment-1853297074.
  2. Maximize window
  3. Unmaximize window
  4. Maximize window
  5. Unmaximize window

Anything else we should know?

No response

GopherTheCoder commented 9 months ago

Can reproduce the issue. I put my Windows task bar to the left of screen, and OBS Studio window will shift right after unmaximizing. Windows 10

Edit: After more test, I found out the issue only happens if task bar is on top/left, not happening if it's on bottom/right.

gxalpha commented 8 months ago

@anrxc when saying "now shifts", did it not shift in prior versions? Could you specify which version is the last where it didn't shift and which is the first where it does shift?

Fenrirthviti commented 8 months ago

As a data point, I've tested again 29.0b3 (compiled against qt6.4.1) and it does not occur there. This is likely a regression in Qt.

EDIT: Confirmed it also does not occur in 29.1.3 (Qt 6.4.3)

RytoEX commented 3 months ago

This may be partially QTBUG-123752.

RytoEX commented 3 weeks ago

QTBUG-123752 will be fixed in Qt 6.7.3 and 6.8+, which should be available for us to use sometime later this year or next year.