Memory leak at reconnecting RTMP

[norihiro]

Operating System Info

Other

Other OS

Fedora 37

OBS Studio Version

Git

OBS Studio Version (Other)

30.0.0-rc1-120-g2d6b6ce05-modified

OBS Studio Log URL

https://obsproject.com/logs/CLbSFxJDmO5eyTqs

OBS Studio Crash Log URL

No response

Expected Behavior

No memory leak

Current Behavior

There is one memory leak

Steps to Reproduce

0. Configure as below
   • Enable Stream Delay
   • Ensure Preserve cutoff point (increase delay) when reconnecting is enabled (default).
1. Start nginx with the RTMP module
2. Start the streaming
3. Wait until ==== Streaming Start =============================================== is displayed on the log.
4. Immediately kill the RTMP server
5. Stop the streaming
6. Exit OBS

Anything else we should know?

A modification below resolved the memory leak. However, I'm afraid it's the right fix. It might be better to just peek the front packet and drop the packet after the packet has correctly been sent.

diff --git a/plugins/obs-outputs/rtmp-stream.c b/plugins/obs-outputs/rtmp-stream.c
index dab8cdd27..ffbbf4235 100644
--- a/plugins/obs-outputs/rtmp-stream.c
+++ b/plugins/obs-outputs/rtmp-stream.c
@@ -659,6 +659,7 @@ static void *send_thread(void *data)
                if (!stream->sent_headers) {
                        if (!send_headers(stream)) {
                                os_atomic_set_bool(&stream->disconnected, true);
+                               obs_encoder_packet_release(&packet);
                                break;
                        }
                }

### Tasks

[norihiro]

@tt2468, this is the bug we were talking on Discord.