search

obsproject / obs-vst

Use VST plugins in OBS
GNU General Public License v2.0
181 stars 56 forks source link

Remove Qt5MacExtras #81

Closed RytoEX closed 3 years ago

RytoEX commented 3 years ago

Description

QtMacExtras is currently not in Qt6 and there's no word on if/when it will be reintroduced. We don't appear to be using it, so let's remove it.

Looking through Qt6 compat stuff - Qt Mac Extras currently isn't in Qt6 and has no ETA on if/when it'll be reintroduced. I was looking at our code base to see if we can just remove it, and I don't actually see that we include QtMacExtras in code. We do use QMacCocoaViewContainer in obs-vst, but I can't tell if that's now included in Qt Widgets directly. QMacCocoaViewContainer is listed under the "See also" section in QtMacExtras docs, but it's shown in the Qt Widgets documentation.

It might be easiest to just make a PR removing it and seeing if it builds and runs on macOS, so let's try it. https://github.com/obsproject/obs-studio/pull/1186 https://doc.qt.io/qt-5/qtmacextras-index.html https://doc.qt.io/qt-5/qtmacextras-module.html https://doc.qt.io/qt-5/qmaccocoaviewcontainer.html

Motivation and Context

Make it easier for us to build everything on Qt6.

How Has This Been Tested?

I ran this through CI on my fork, and it compiled. Currently awaiting testing from macOS users (@DDRBoxman, @PatTheMav) to see if it runs without issue.

https://github.com/RytoEX/obs-studio/tree/remove-qtmacextras-test https://github.com/RytoEX/obs-studio/runs/2079158979

Types of changes

Checklist:

DDRBoxman commented 3 years ago

Just tried the above build on my MacBook and loaded up the rough rider VST just fine

RytoEX commented 3 years ago

I had previously marked this as draft to prevent merging before tests confirmed this worked. With a confirmation above, I've marked this "ready for review" so it can be reviewed and/or merged.

RytoEX commented 3 years ago

Looks like obsproject/obs-studio#4361 was merged. With that and the above test feedback, I think this is safe to merge.