Remove unused include - Githubissues

obsproject / obs-vst

Use VST plugins in OBS

GNU General Public License v2.0

181 stars 56 forks source link

Remove unused include #96

Closed gxalpha closed 2 years ago

gxalpha commented 2 years ago

Description

Removes an unneeded import.

Motivation and Context

025ab52 removed QMacCocoaViewContainer, but not the #include. However, the that isn't needed anymore.

How Has This Been Tested?

Still compiles on macOS (12.0.1).

Types of changes

Code cleanup (non-breaking change which makes code smaller or more readable)

Checklist:

[x] My code has been run through clang-format.
[x] I have read the contributing document.
[x] My code is not on the master branch.
[x] The code has been tested.
[x] All commit messages are properly formatted and commits squashed where appropriate.
[x] I have included updates to all appropriate documentation.

notr1ch commented 2 years ago

Might be good to fix the #ifs to #if defined() while we're at it.

gxalpha commented 2 years ago

@notr1ch that would be defined(_WIN32) or ifdef _WIN32 then, right? (I don't have a windows build environment so I'm a little hesitant to touch this)

notr1ch commented 2 years ago

Yeah, #if tests a constant value, #if defined(xx) tests if xx is defined. Given many build environments simply pass -DVARIABLE and not -DVARIABLE=1, testing with #if can produce wrong results.

And yes it should also be _WIN32 not WIN32.

WizardCM commented 2 years ago

Verified this builds on Windows and Linux.