obsproject / obs-vst

Use VST plugins in OBS
GNU General Public License v2.0
181 stars 56 forks source link

obs-vst: Modify bug in VSTPlugin::closeEditor() #97

Closed walker-WSH closed 2 years ago

walker-WSH commented 2 years ago

Description

VSTPlugin::closeEditor() can be invoked again from VSTPlugin::closeEditor(). Second closeEditor() is invoked from editorWidget->close() in first closeEditor(). In second func, editorWidget will be set with NULL, then deleteLater() in first func is using empty editorWidget

Motivation and Context

modify closeEditor()

How Has This Been Tested?

select VST-1, open editor UI; switch to VST-2

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

walker-WSH commented 2 years ago

This PR may cause effEditClose can't be invoked. So I close this PR and will push another solution. https://github.com/obsproject/obs-vst/pull/100