obsproject / obs-vst

Use VST plugins in OBS
GNU General Public License v2.0
181 stars 56 forks source link

obs-vst: Fix crash caused by mult-thread accessing to VSTPlugin::effect #99

Closed walker-WSH closed 2 years ago

walker-WSH commented 2 years ago

Description

fix thread-safe issue for effect

VSTPlugin::unloadEffect() is called from UI thread. VSTPlugin::process is called from audio source

Motivation and Context

fix crash

How Has This Been Tested?

select a vst for audio source; keep switching vst

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

jp9000 commented 2 years ago

Seems to have a conflict since the other PR was merged for closeEditor.

walker-WSH commented 2 years ago

Seems to have a conflict since the other PR was merged for closeEditor.

Conflict is fixed. I have to fix clang error tomorrow because no environment now.

walker-WSH commented 2 years ago

@jp9000 It is ready to be merged now