obsproject / obs-websocket

Remote-control of OBS Studio through WebSocket
GNU General Public License v2.0
3.84k stars 704 forks source link

requesthandler: Deprecate SetStreamServiceSettings #1114

Closed tytan652 closed 1 year ago

tytan652 commented 1 year ago

Description

RFC 39 plan to overhaul services in OBS Studio, unfortunately SetStreamServiceSettings use two functions that needs to be deprecated and then dropped while landing RFC 39 to avoid issues. So SetStreamServiceSettings also must be deprecated.

obs_frontend_save_streaming_service, plugin should not be able to override what is saved by the settings window.

Since output selection is planned to be moved in settings, SetStreamServiceSettings allows to set a service that might mismatch the used output (and even encoders depending on the protocol and services).

At the present time, I can't promise replacement for those functions in RFC 39.

Motivation and Context

Make a clean deprecation plan for those functions.

How Has This Been Tested?

Tested OS(s):

Types of changes

Checklist: