obsproject / obs-websocket

Remote-control of OBS Studio through WebSocket
GNU General Public License v2.0
3.8k stars 701 forks source link

OBS Websocket not reporting changes to text source #1157

Closed slords closed 6 months ago

slords commented 12 months ago

Operating System Info

Windows 11

Other OS

No response

OBS Studio Version

29.1.3

OBS Studio Version (Other)

No response

OBS Studio Log URL

https://obsproject.com/logs/

OBS Studio Crash Log URL

No response

Expected Behavior

I've got OBS connected to Bitfocus Companion. Companion is successfully connecting to the websocket of OBS. This works and I'm able to interface with most things successfully. I'm also using OBS Lyrics 2.0.0 to display song information on a page. I'm using Title Source for the song title and Static Source for the song number. OBS is providing variables to Companion via websocket for the text that is being pushed into the text sources. The song lyrics are always being updated but the song title and number are updated about 70% of the time. The text sources are updated correctly in OBS but the data isn't being pushed via websocket updates consistently. If I have 5 songs setup and cycle through them sometimes it will go through all of them without issues. But, most of the time it will push for song 1, 2, 4, 5. If from song 4 I go backwards to song 3 it will update but going from song 2 to 3 will not update. I'm not sure where this issue is happening. My guess would be in the websocket area. These are the only variables that aren't being updated correctly that I could find. Since there is no crash I'm not sure how to proceed.

Current Behavior

When song title and song number text sources are updated their values should be pushed via websocket like all other updates.

Steps to Reproduce

  1. Use OBS Lyrics 2.0.0 to change text sources
  2. Connect Companion to websocket
  3. Change songs and observe that OBS updates but Companion variables (via websockets) don't update. ...

Anything else we should know?

Not at this time

tt2468 commented 12 months ago

Without a description of the raw WebSocket requests that are being sent, along with their timings, we cannot help here. Third party clients add a large amount of complication and unknown variables to be able to trust the results from them.

I would assume this is an issue with bitfocus, as we would have 100% had issue reports months ago about this already.

slords commented 11 months ago

I've linked to the bug I've opened in the companion module. It appears this might be a bug where updates to the text aren't being reported via websocket. I've verified the value is correct when queried. I've updated the subject to reflect what appears to be the issue.

slords commented 11 months ago

I looks like as of 29.x that OBS reports change to text. Any chance of getting this added to the websocket?

https://docs.obsproject.com/reference-sources#source-signals

https://github.com/bitfocus/companion-module-obs-studio/issues/237#issuecomment-1661384862