search

obsproject / obs-websocket

Remote-control of OBS Studio through WebSocket
GNU General Public License v2.0
3.79k stars 701 forks source link

Bug: "Save/GetSourceScreenshot" (Doesn't Match OBS Behaviour) #1213

Closed Joefis-x20s closed 1 month ago

Joefis-x20s commented 3 months ago

Operating System Info

Other

Other OS

Win/MacOS

OBS Studio Version

Other

OBS Studio Version (Other)

30.1

obs-websocket Version

5.1.0

OBS Studio Log URL

N/A

OBS Studio Crash Log URL

No response

Expected Behavior

Get/SaveScreenshot should match OBS Source when the Source has been cropped/scaled via a filter.

Testing Source: A 1920x1080 Colour Source w/ Crop/Pad of right:1300 bottom:500

Expected behaviour (using OBS frontend to save a source screenshot): Screenshot 2024-03-20 13-08-17

Current Behavior

Get/SaveScreenshot should match OBS Source when the Source has been cropped/scaled via a filter.

Testing Source: A 1920x1080 Colour Source w/ Crop/Pad of right:1300 bottom:500

Currently: test1

Steps to Reproduce

  1. Create a source.
  2. Add a Crop/Pad or Scaling/Aspect Ratio Filter and change the resolution of the original source
  3. Use Get/SaveScreenshot Request on the source. See that the result doesn't match OBS

Anything else we should know?

OBS had the same issue in Jan 2024 but fixed with this PR: https://github.com/obsproject/obs-studio/pull/10077