obsproject / obs-websocket

Remote-control of OBS Studio through WebSocket
GNU General Public License v2.0
3.91k stars 706 forks source link

No "bandwidth test enabled" dialog when starting stream via websocket #951

Open MattyFresh68 opened 2 years ago

MattyFresh68 commented 2 years ago

Operating System Info

Windows 11

Other OS

No response

OBS Studio Version

27.2.4

OBS Studio Version (Other)

No response

obs-websocket Version

4.9.1

OBS Studio Log URL

https://obsproject.com/logs/rptNHzZGpcMsGlgG

OBS Studio Crash Log URL

No response

Expected Behavior

When starting a stream remotely via websocket, the "bandwidth test enabled" dialog should still pop up, else you may be "live" without actually being live and no indication to show otherwise.

Current Behavior

Currently if you have bandwidth test enabled, and start a stream via websoclet, it just silently starts the stream without any indication that it isn't actually being pushed out live.

Steps to Reproduce

1.Connect acct to twitch in obs settings > stream 2.Check box to enable bandwidth test 3.Start stream via websocket(in this case, was done remotely using Touch Portal) ...

Anything else we should know?

Here is a video demonstrating starting stream via UI in obs and remotely via touch portal. https://streamable.com/i1lo7r

tt2468 commented 2 years ago

Requires upstream changes in OBS. The bandwidth test dialog code is only in the callback for the Start Streaming code, and needs to be moved to the "lower level" callback that also serves obs_frontend_start_streaming()

negreality commented 12 months ago

It would also be beneficial in my use case to see a boolean in a StreamStateChanged event indicating the bandwidth test mode state.