obsproject / obs-websocket

Remote-control of OBS Studio through WebSocket
GNU General Public License v2.0
3.8k stars 701 forks source link

Bug: 5.1.0: Build breaks with clang: token pasting of ',' and __VA_ARGS__ is a GNU extension #974

Closed yurivict closed 6 months ago

yurivict commented 1 year ago

Operating System Info

Other

Other OS

FreeBSD

OBS Studio Version

27.2.4

OBS Studio Version (Other)

No response

obs-websocket Version

5.0.1

OBS Studio Log URL

n/a

OBS Studio Crash Log URL

No response

Expected Behavior

n/a

Current Behavior

In file included from /disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/WebSocketServer.cpp:26:
In file included from /disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/WebSocketServer.h:30:
In file included from /disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/rpc/WebSocketSession.h:27:
/disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/../eventhandler/../plugin-macros.generated.h:23:65: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
#define blog(level, msg, ...) blog(level, "[obs-websocket] " msg, ##__VA_ARGS__)
                                                                ^
/disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/../eventhandler/../plugin-macros.generated.h:23:67: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
#define blog(level, msg, ...) blog(level, "[obs-websocket] " msg, ##__VA_ARGS__)
                                                                  ^
/disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/../eventhandler/../plugin-macros.generated.h:23:67: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
/disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/../eventhandler/../plugin-macros.generated.h:23:65: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
#define blog(level, msg, ...) blog(level, "[obs-websocket] " msg, ##__VA_ARGS__)
                                                                ^
/disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/../eventhandler/../plugin-macros.generated.h:23:65: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
/disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/../eventhandler/../plugin-macros.generated.h:23:65: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
/disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/../eventhandler/../plugin-macros.generated.h:23:65: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
/disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/../eventhandler/../plugin-macros.generated.h:23:65: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
/disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/../eventhandler/../plugin-macros.generated.h:23:65: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
/disk-samsung/freebsd-ports/multimedia/obs-websocket/work/obs-websocket-5.0.1/src/websocketserver/../eventhandler/../plugin-macros.generated.h:23:67: error: token pasting of ',' and __VA_ARGS__ is a GNU extension [-Werror,-Wgnu-zero-variadic-macro-arguments]
#define blog(level, msg, ...) blog(level, "[obs-websocket] " msg, ##__VA_ARGS__)
                                                                  ^

Steps to Reproduce

regular build

Anything else we should know?

clang-14 FreeBSD 13.1

tt2468 commented 6 months ago

obs-websocket is no longer designed to be built out of tree. As such, I believe this issue is no longer relevant.