obspy / reporter

ObsPy test reporter app
3 stars 5 forks source link

try to make links in tracebacks clickable #10

Closed megies closed 10 years ago

megies commented 10 years ago

for use with imgur links in image test tracebacks introduced by obspy/obspy#822

barsch commented 10 years ago

http://tests.obspy.org/15212/ works - you could even show the images directly in the traceback

megies commented 10 years ago

you could even show the images directly in the traceback

huh.. yeah. interesting. didn't think of that..

megies commented 10 years ago

@barsch, i pushed to master, trying to display the images directly. can update the server again please?

megies commented 10 years ago

Nice! :)

megies commented 10 years ago

..any chance to get something like the github image comparison slider script?

joking.. ;)

barsch commented 10 years ago

link?

barsch commented 10 years ago

something like this http://zurb.com/playground/twentytwenty? should be no problem ...

megies commented 10 years ago

e.g. https://github.com/obspy/obspy/commit/202a3291eb703ad6039c56b7dd1dd30006d481de

EDIT: but yeah.. the slider at your link looks pretty much like what would be nice here

barsch commented 10 years ago

nice tool didn't know about that - anyway it seems not to be free to use or ?

megies commented 10 years ago

dunno.. you're the web guru ;) if the github one doesnt work.. somthing like you posted (showcased here: http://www.canada-goose.com/counterfeit/) would also be nice..

barsch commented 10 years ago

its not about "doesn't work" - ofc I could "reuse" githubs implementation however I don't see it marked as free to use - there is no license - no copyright info whatsoever :/

megies commented 10 years ago

well then.. how about just dropping them an email to support?

barsch commented 10 years ago

go ahead ;)

megies commented 10 years ago

can you point me at the lines of code that would be reused or something? can't be bothered with trying to make sense of the source of that site..

barsch commented 10 years ago

oh my didn't look into details yet - just ask if they offer this as lib somewhere free to use for oss - i doubt it but you feel free to try - anyway I will look into other public solutions

megies commented 10 years ago

Ok.. sounded like it's technically feasible but just legally unclear. Anyway, dropped them a mail. The other slider thing looked pretty Ok, too.