search

obsrvbl-oss / flowlogs-reader

Command line tool and Python library for working with AWS VPC Flow Logs
Apache License 2.0
136 stars 25 forks source link

Catch PaginationError #28

Closed bbayles closed 7 years ago

bbayles commented 7 years ago

Re: #27, this PR catches PaginationError such that the iterator doesn't fail if botocore returns the same nextToken twice.

I considered adding a log entry for this case, but I'd like to get logging ettiquette right since this is a library, and that seems outside the scope of the issue here.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling c63e4a8b3e5a724705a105a873bc585e93fef667 on paginate-errors into 6b32a22ffc15da44fe93faa6b2960ced1acccdc1 on master.

mjschultz commented 7 years ago

LGTM