search

obumnwabude / github-invite

A web app that can accept a GitHub user name and send them an invitation to join a GitHub organisation.
https://obumnwabude.github.io/github-invite/
MIT License
3 stars 8 forks source link

Add user to list of teams #5

Open TotallyInformation opened 3 years ago

TotallyInformation commented 3 years ago

Hi, is it possible to add the invited user to a list of team names?

obumnwabude commented 3 years ago

Please I don't understand. How exactly do you mean? Please explain your question more

TotallyInformation commented 3 years ago

There is a GitHub API that lets you assign users to a team in an organisation. In the GitHub admin ui, when inviting a user to an organisation, you can also select what teams you want to add them to.

So really, this package needs to be able to do something similar.

obumnwabude commented 3 years ago

There is a GitHub API that lets you assign users to a team in an organisation. In the GitHub admin ui, when inviting a user to an organisation, you can also select what teams you want to add them to.

So really, this package needs to be able to do something similar.

Yes you are right. That's a feature that would be nice for this package to have.

Out of the 4 different versions of this github-invite, the npm-package and frontend-only versions are accessed directly by the admin and take the admin's personal access token. I think it's okay to incorporate what you are requesting in these versions. That the admin selects the team in which the user they invite will join at invitation point, just as you are demanding. I will work towards this.

As for the Node Monolithic and Firebase versions, that just provide an interface for the invitee to be invited; I don't think it's fine to add the option for the invitee to select their team at point of themselves getting invited. Do you think it is okay to ask them to choose their teams at the point the invite themselves? Let me hear your opinion please

TotallyInformation commented 3 years ago

Hi, thanks for the response.

We certainly wouldn't be letting invitees chose their own teams I'm afraid, that is set up front by the organisation/team administrator. We have a variety of teams who work on a variety of projects, some more sensitive than others.

obumnwabude commented 3 years ago

Okay, Great!

I will update the admin facing npm-package and frontend-only versions to include teams. Thanks for raising this issue.

Is there any other feature you'll want to see?

TotallyInformation commented 3 years ago

Great, thanks! Nothing else I can spot at the moment thanks.