obynio / anki-japanese-furigana

Anki add-on providing support for adding furigana on Japanese text
https://ankiweb.net/shared/info/678316993
GNU General Public License v3.0
17 stars 5 forks source link

Address a couple miscellaneous issues #21

Closed ahlec closed 1 year ago

ahlec commented 1 year ago

This PR focuses on fixing up a couple of tiny issues:

I've tested these changes on both Anki 2.1.54 and Anki 2.1.49.

Also, I wasn't sure (this is my first open-source project) if I should continue to maintain my fork, or push branches on this one now that I'm a contributor. If it wasn't OK for me to push to this repo, I'll continue to use my fork for any future work!

obynio commented 1 year ago

Hello, sorry for the late answer. Yeah seems like good changes, we can merge that !

this is my first open-source project

Well as far as I can see you make quality contributions ! It's a small open-source project but what matters is the fun we get doing it 🙂

Also I wasn't sure if I should continue to maintain my fork, or push branches on this one now that I'm a contributor.

You can push branches here or use your own project. Choose what's the more convenient for you 👍