search

obynio / anki-japanese-furigana

Anki add-on providing support for adding furigana on Japanese text
https://ankiweb.net/shared/info/678316993
GNU General Public License v3.0
21 stars 7 forks source link

Add spaces before readings #35

Closed omergreen closed 9 months ago

omergreen commented 9 months ago

Fix issues #32 and #29

omergreen commented 9 months ago

We should probably also strip spaces from the sentence when removing furigana?

obynio commented 9 months ago

Hello @omergreen, that's a good change. Concerning your suggestion, yes please, can you please make sure to remove the spaces from the sentence when removing furiganas ?

omergreen commented 9 months ago

Done, I've also updated the tests and made sure they pass

obynio commented 9 months ago

This was tested, merged and release in 1.4.6. Thank you for your contribution 🫡