search

ocadotechnology / codeforlife-portal-backend

Other
0 stars 16 forks source link

dev env - setup #290

Closed SKairinos closed 3 months ago

SKairinos commented 7 months ago

eslint, import sorting, prettier, typescript

SKairinos commented 3 months ago

I have created a new repo to contain portal's FE. Because this repo is new, there is no PR. Rather, please review:

SKairinos commented 3 months ago

side note, I have created this task to deal with turning portal-react into the portal-backend repo.

faucomte97 commented 3 months ago

@SKairinos reviewed, the dev branch looks good to me. The branch protection rules, to me look good too. Just make sure to add the relevant status checks where needed, and maybe just double-check whether the rules allow for whatever the cfl-bot might need to do, but as far as I could tell it was all good. The pipeline - I wasn't sure what to check, if you mean the workflow that is called by the frontend repo from the workspace repo then I have already reviewed that in your workspace PR and it looked good to me.