Add gmail/outlook buttons to reset password page

ocadotechnology / codeforlife-portal

The portal code for Code for Life

Other

49 stars 63 forks source link

Add gmail/outlook buttons to reset password page #2297

Closed lauracumming closed 1 month ago

lauracumming commented 2 months ago

Task Description

Acceptance Criteria

[ ] ...
[ ] ...

Analytics Requirements

[ ] ...

Copywrite Requirements

[ ] ...

SKairinos commented 1 month ago

accidentally committed straight to master. why was this possible? Please review and if there are change requests, I will revert the commit and make it a legit PR https://github.com/ocadotechnology/codeforlife-portal/commit/8ae60b9be21f9a851f99a602ea3a58b5f4a1a3ab

evemartin commented 1 month ago

The buttons look good to me!

lauracumming commented 1 month ago

[x] Check Cookie banner: banner loads, categories in the right order, cookies disabled by default
[x] Check Rapid Router: game loads, can solve a level, can save a workspace, can create a level, can save a level, scores get saved, scoreboard loads
[x] Check OS on browserstack
[x] Approved on production

lauracumming commented 1 month ago

Does this work for anyone on production? Please check

evemartin commented 1 month ago

It also doesn't work for me - I think it's because we changed the Dotdigital domain after this was deployed, so the gmail button is still searching for emails sent from the old domain :( I think Florian added it as a bug for the last sprint in the sprint checklist spreadsheet!

lauracumming commented 1 month ago

Okay. I'll add this into this sprint, as i thought it was just that it wasn't searching correctly but it still opened the right application.

evemartin commented 1 month ago

Sounds good - although it does still open the right application for me, it just searches wrong. What happens for you?

lauracumming commented 1 month ago

Task added to this sprint https://app.zenhub.com/workspaces/code-for-life-sprint-board-5dc58d4a85c6bd00010b8148/issues/gh/ocadotechnology/codeforlife-portal/2306