search

ocadotechnology / codeforlife-portal

The portal code for Code for Life
https://www.codeforlife.education/
Other
51 stars 79 forks source link

fix join class request error #2301

Closed SKairinos closed 5 months ago

SKairinos commented 6 months ago

when entering a valid access code of a class to join, it says it cannot find it

image_720.png
SKairinos commented 6 months ago

@faucomte97 said: "The message is purposefully vague because we do not want to enumerate existing class codes - they are indeed not personal data like Stefan mentioned, however they are used in the login form for the students. So enumerating existing class codes means less options for hackers to try in the login form"

lauracumming commented 6 months ago

Thanks - still relevant

SKairinos commented 6 months ago

LGTM

image.png
SKairinos commented 6 months ago

@lauracumming, check needed

lauracumming commented 5 months ago

LGTM

SKairinos commented 5 months ago

LGTM