Closed Jibran1998 closed 1 month ago
faucomte97
commented
1 month ago Hi @Jibran1998, thanks for working on one of our tasks!
Before we can go ahead and review your PR, could you please read through our Contributing Agreement and follow the steps at the bottom to become a verified contributor.
Once that's done, I will go ahead and approve the checks on this PR and review it.
Thanks!
Jibran1998
commented
1 month ago Hi @faucomte97, I have done what you have asked. Here is the PR: 109. Thanks
Jibran1998
commented
1 month ago Thanks @faucomte97 for the review. I have made the requested changes. 🤗
Jibran1998
commented
1 month ago Hi @faucomte97, I have signed the contribution agreement but still the check is failing. Can you please assist here.
faucomte97
commented
1 month ago Hi @Jibran1998, yes I have noticed that too 😔 something must be wrong with our check. Your PR looks good and I've approved it, but if you don't mind I'll leave it open for now so that my colleague and I can diagnose our check and run some tests on Tuesday. Hopefully we'll be able to sort it out then 😀
Jibran1998
commented
1 month ago @faucomte97 thanks for the response. Yes, we can keep the PR open. I would also be happy to assist with the checks if needed. It seems that the contributors' string casing isn't handled correctly when checking for contributors. I committed my code using Jibran19983@gmail.com (uppercase J), while in CONTRIBUTING.md it is written as jibran19983@gmail.com (lowercase j). 😄
faucomte97
commented
1 month ago Hi @Jibran1998, we have fixed our workflow and it has now passed. I will go ahead and merge in your pull request now 🙂 Your contribution will be deployed to our staging website, and once we've manually checked it a few times we will deploy it to our production site. Thanks again for your contribution to our project! 😄 🙏🏻
This PR is fix for #2306
Description
Changed the URL for Gmail redirect to use the new Domain instead of Dot Digital (older) one.
Bug
Fixed
How Has This Been Tested?
Checklist:
This change is