Closed besque closed 1 month ago
Ah, I suppose the tests are failing because of the prefix, the test would be expecting the field name without the prefix. I've modified the InvitedTeacherForm in teach.py to keep the original field names while still getting the ID's we want.
Hope this fixes it, really sorry π
Please check and let me know, Thank you!
@besque It looks like you're getting a different error now - seems like name
isn't an attribute of the fields
My apologies, I'm looking into this
No worries! The test logs should hopefully have clear error messages but if you have any questions feel free to ask π
Ahh, I was trying to acess the field's name from the field object, I've updated the code to acess the field name directly from the dictionary key instead.
This should do the job
Hi @besque, I might be wrong but I think you just need to update the failing test so that the correct ID is used - similarly to how this test uses the full ID with the prefix too
hey @faucomte97,
You're right, I've updated it so that even the prefix is included so it shouldn't give that error anymore.
Sorry for the delay π
This pr fixes issue #2304
Description
Fixed missing JavaScript functionality in teacher invitation registration form. Added prefix to match main registration form's field IDs, which restored:
Root cause:
prefix = 'teacher_signup'
to InvitedTeacherForm class to match the main registration form's ID patternThis ensures the JavaScript can properly bind to the password input fields
Bug
When teachers were invited to join a school, the password registration form was missing the reveal password icon and strength checker that exists in the main registration form.
Fixed
How Has This Been Tested?
Checklist:
This change isβ