Account form is broken - Githubissues

faucomte97 commented 3 weeks ago

Describe the bug The edit account details form, both for Teacher and Independent Student, is broken. Since 01/11/2024, for no apparent reason, the form has stopped processing data properly.

The form allows the user to do 3 things:

update their name
update their email address
update their password

In each case, the user needs to input their current password to submit the password. The name field is pre-populated, and every other field is optional.

However, now, the form acts like the new password field is required. Because of that, the user can't just update their name or email address without changing password, which is not the intended behaviour.

To Reproduce Steps to reproduce the behaviour:

Log in as a teacher or an independent student.
Go to the update account details form.
Change the value of the name field in the form.
Input your password in the "current password" field.
Click the submit button.
Notice that the form complains that the new password field does not meet the password criteria, despite the field being optional.

This means the form submitted the new password field as an empty string instead of ignoring it.

Expected behaviour The form should only check the fields that have been filled in.

Screenshots Screenshot from 2024-11-02 02-47-19