search

ocadotechnology / codeforlife-portal

The portal code for Code for Life
https://www.codeforlife.education/
Other
49 stars 78 forks source link

misplaced schools #87

Closed robertbrignull closed 10 years ago

robertbrignull commented 10 years ago

There's a school 'NLNG School Bonny' positioned off the coast of Africa, presumably latitude 0, longitude 0. So there's probably a bug in the postcode lookup function as that shouldn't happen.

josephezammit commented 10 years ago

This is just where they have invalid postcodes, and we set the town, lat and long to 0 to flag that.

Schools with their town = 0 should be excluded from the map.

robertbrignull commented 10 years ago

You're right, 'NLNG' is one of the American schools. I thought there was just the one but I guess all five are stacked up there. So it's not a bug in the lookup, they just need to be excluded from the map.