search

ocadotechnology / django-nuit

A front-end framework based upon Zurb Foundation for Django applications
Apache License 2.0
6 stars 5 forks source link

Python 3 compatibility #24

Closed zaibacu closed 8 years ago

zaibacu commented 8 years ago

Python 3 got renamed urlparse module to urllib.parse, due to that, whole package does not work on Python 3.

benbacardi commented 8 years ago

Are there utilities in the six package we can use for these situations?

zaibacu commented 8 years ago

Yes, using six is better solution, fixed it

mikebryant commented 8 years ago

Looking good so far :)

If you take the 

matrix:
  allow_failures:
  - python: 3.5
    env: DJANGO_VERSION=">=1.8, < 1.9"
  - python: 3.5
    env: DJANGO_VERSION=">=1.9, < 1.10"

chunk out of .travis.yml the pull request will reflect the results of the python3 tests.

mikebryant commented 8 years ago

The current error might be fixed by using get_method_function() from six, instead of __func__. Partly a guess though, I haven't tested this

mikebryant commented 8 years ago

@zaibacu Could you have a look at #25 and confirm you're happy with the changes I made to your commits? :)

mikebryant commented 8 years ago

Closed in favour of #25